Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RGS stats for August 2024. #3267

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Aug 22, 2024

This updates the RGS metrics to the latest measurements for V2 gossip.

@arik-so
Copy link
Contributor Author

arik-so commented Aug 22, 2024

I think we might wanna remove the processing times considering the amount of variance they might exhibit depending on the environment.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.66%. Comparing base (0d7ae86) to head (c4dea14).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
+ Coverage   89.82%   90.66%   +0.84%     
==========================================
  Files         125      126       +1     
  Lines      102830   110644    +7814     
  Branches   102830   110644    +7814     
==========================================
+ Hits        92368   100318    +7950     
+ Misses       7752     7740      -12     
+ Partials     2710     2586     -124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt
Copy link
Collaborator

Yea, I think lets remove the processing times. Otherwise lgtm.

@moneyball
Copy link
Contributor

Understanding the processing time is very important. People want to know whether app startup latency is going to be 0.5 seconds or 5 seconds or 50 seconds.

Can we include processing time along with which processor was tested? Or bonus points for a couple of data points so we have a range?

@moneyball
Copy link
Contributor

What is the explanation for the data reduction with the new measurement?

@arik-so
Copy link
Contributor Author

arik-so commented Aug 22, 2024

In that case perhaps we should publish processing times for three-four different environments, say a mobile phone, an Intel chipset laptop, and an ARM chipset computer? I could also test-run it on a Pi.

@TheBlueMatt
Copy link
Collaborator

Any update here?

@arik-so
Copy link
Contributor Author

arik-so commented Sep 6, 2024

Mobile benchmarks were blocked on Swift bindings. I'll be able to run them today.

@moneyball
Copy link
Contributor

What were the results @arik-so ?

@arik-so
Copy link
Contributor Author

arik-so commented Sep 11, 2024

Eh, sadly more complicated than anticipated to just run a couple benchmarks on mobile. Still pending Apple reinstating my lapsed developer account, without which Xcode won't allow me to run anything on a real mobile device.

@arik-so
Copy link
Contributor Author

arik-so commented Sep 11, 2024

I asked @jurvis to run the benchmarks instead, and updated the values accordingly. These new times are significantly faster than the old times because the previous times were measured on an iPhone 11 Pro.

@TheBlueMatt
Copy link
Collaborator

Cool, should this be un-draft-ed now?

@arik-so arik-so marked this pull request as ready for review September 11, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants